-
Notifications
You must be signed in to change notification settings - Fork 108
feat: import snippets #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: core-beta
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use logical properties for native RTL support.
src/js/components/Import/FromFileUpload/components/ImportResultDisplay.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromOtherPlugins/components/SimpleSnippetTable.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromOtherPlugins/components/SimpleSnippetTable.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromFileUpload/components/DragDropUploadArea.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromFileUpload/components/DragDropUploadArea.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromFileUpload/components/DuplicateActionSelector.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromFileUpload/components/SelectedFilesList.tsx
Outdated
Show resolved
Hide resolved
…tDisplay.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ctionTable.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tDisplay.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tDisplay.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…elector.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ions.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…play.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ions.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…oadArea.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…oadArea.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…esList.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Download and install |
src/js/components/Import/FromOtherPlugins/components/SimpleSnippetTable.tsx
Outdated
Show resolved
Hide resolved
src/js/components/Import/FromOtherPlugins/components/StatusDisplay.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…play.tsx Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
# Conflicts: # src/php/class-plugin.php
…code-snippets into import-snippets # Conflicts: # src/php/class-plugin.php
|
|
||
| {result.warnings && result.warnings.length > 0 && ( | ||
| <div style={{ marginBlockStart: '12px' }}> | ||
| <h4 style={{ margin: '0 0 8px 0', fontSize: '14px', color: '#d63638' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h4 style={{ margin: '0 0 8px 0', fontSize: '14px', color: '#d63638' }}> | |
| <h4 style={{ margin: '0 0 8px', fontSize: '14px', color: '#d63638' }}> |
| }) => { | ||
| return ( | ||
| <div className="selected-files" style={{ marginBlockEnd: '20px' }}> | ||
| <h3 style={{ margin: '0 0 12px 0', fontSize: '14px', fontWeight: '600' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h3 style={{ margin: '0 0 12px 0', fontSize: '14px', fontWeight: '600' }}> | |
| <h3 style={{ margin: '0 0 12px', fontSize: '14px', fontWeight: '600' }}> |
| /> | ||
|
|
||
| <ImportCard> | ||
| <h2 style={{ margin: '0 0 1em 0' }}>{__('Choose Files', 'code-snippets')}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h2 style={{ margin: '0 0 1em 0' }}>{__('Choose Files', 'code-snippets')}</h2> | |
| <h2 style={{ margin: '0 0 1em' }}>{__('Choose Files', 'code-snippets')}</h2> |
| <div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginBlockEnd: '10px' }}> | ||
| <div> | ||
| <h3 style={{ margin: '0' }}>{__('Available Snippets', 'code-snippets')} ({importWorkflow.availableSnippets.length})</h3> | ||
| <p style={{ margin: '0.5em 0 1em 0', color: '#666' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p style={{ margin: '0.5em 0 1em 0', color: '#666' }}> | |
| <p style={{ margin: '0.5em 0 1em', color: '#666' }}> |
| return ( | ||
| <ImportCard variant="controls"> | ||
| <label htmlFor="importer-select"> | ||
| <h2 style={{ margin: '0 0 1em 0' }}>{__('Select Plugin', 'code-snippets')}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h2 style={{ margin: '0 0 1em 0' }}>{__('Select Plugin', 'code-snippets')}</h2> | |
| <h2 style={{ margin: '0 0 1em' }}>{__('Select Plugin', 'code-snippets')}</h2> |
| <ImportCard> | ||
| <div style={{ textAlign: 'center', padding: '40px 20px', color: '#666' }}> | ||
| <div style={{ fontSize: '48px', marginBlockEnd: '16px' }}>📭</div> | ||
| <h3 style={{ margin: '0 0 8px 0', fontSize: '18px', color: '#333' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h3 style={{ margin: '0 0 8px 0', fontSize: '18px', color: '#333' }}> | |
| <h3 style={{ margin: '0 0 8px', fontSize: '18px', color: '#333' }}> |
| }} | ||
| > | ||
| <div style={{ fontSize: '48px', marginBlockEnd: '10px', color: '#666' }}>📁</div> | ||
| <p style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '500' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '500' }}> | |
| <p style={{ margin: '0 0 8px', fontSize: '16px', fontWeight: '500' }}> |
| }) => { | ||
| return ( | ||
| <ImportCard> | ||
| <h2 style={{ margin: '0 0 1em 0' }}>{__('Duplicate Snippets', 'code-snippets')}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h2 style={{ margin: '0 0 1em 0' }}>{__('Duplicate Snippets', 'code-snippets')}</h2> | |
| <h2 style={{ margin: '0 0 1em' }}>{__('Duplicate Snippets', 'code-snippets')}</h2> |
| </span> | ||
| </div> | ||
| <div style={{ flex: 1 }}> | ||
| <h3 style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '600' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h3 style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '600' }}> | |
| <h3 style={{ margin: '0 0 8px', fontSize: '16px', fontWeight: '600' }}> |
| : __('Import Failed', 'code-snippets') | ||
| } | ||
| </h3> | ||
| <p style={{ margin: '0 0 8px 0', color: '#666' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p style={{ margin: '0 0 8px 0', color: '#666' }}> | |
| <p style={{ margin: '0 0 8px', color: '#666' }}> |
ramiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent design - 4px border-radius.
| } | ||
|
|
||
| return ( | ||
| <table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px', tableLayout: 'fixed' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px', tableLayout: 'fixed' }}> | |
| <table className="wp-list-table widefat fixed striped" style={{ borderRadius: '4px', tableLayout: 'fixed' }}> |
| padding: '3px 6px', | ||
| fontSize: '10px', | ||
| textTransform: 'uppercase', | ||
| borderRadius: '3px' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| borderRadius: '3px' | |
| borderRadius: '4px' |
| </div> | ||
| </div> | ||
|
|
||
| <table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px' }}> | |
| <table className="wp-list-table widefat fixed striped" style={{ borderRadius: '4px' }}> |
| const cardStyle: React.CSSProperties = { | ||
| backgroundColor: '#ffffff', | ||
| padding: '25px', | ||
| borderRadius: '5px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| borderRadius: '5px', | |
| borderRadius: '4px', |
No description provided.