Skip to content

Conversation

@louiswol94
Copy link
Contributor

No description provided.

@louiswol94 louiswol94 changed the base branch from core to core-beta November 27, 2025 19:49
@louiswol94 louiswol94 added the run-tests Trigger automated tests label Nov 28, 2025
Copy link
Contributor

@ramiy ramiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use logical properties for native RTL support.

louiswol94 and others added 23 commits December 5, 2025 11:05
…tDisplay.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ctionTable.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tDisplay.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tDisplay.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…elector.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ions.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…play.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ions.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…oadArea.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…oadArea.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…tionSelector.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…esList.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
@louiswol94 louiswol94 requested a review from ramiy December 5, 2025 09:12
@louiswol94 louiswol94 added the build Adding this label will trigger the zip build action label Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Download and install

📦 code-snippets.3.9.2.zip

louiswol94 and others added 8 commits December 18, 2025 14:55
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…ppetTable.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
…play.tsx

Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
Co-authored-by: Rami Yushuvaev <rami@codesnippets.pro>
@louiswol94 louiswol94 requested a review from ramiy December 18, 2025 12:57
# Conflicts:
#	src/php/class-plugin.php
…code-snippets into import-snippets

# Conflicts:
#	src/php/class-plugin.php

{result.warnings && result.warnings.length > 0 && (
<div style={{ marginBlockStart: '12px' }}>
<h4 style={{ margin: '0 0 8px 0', fontSize: '14px', color: '#d63638' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h4 style={{ margin: '0 0 8px 0', fontSize: '14px', color: '#d63638' }}>
<h4 style={{ margin: '0 0 8px', fontSize: '14px', color: '#d63638' }}>

}) => {
return (
<div className="selected-files" style={{ marginBlockEnd: '20px' }}>
<h3 style={{ margin: '0 0 12px 0', fontSize: '14px', fontWeight: '600' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3 style={{ margin: '0 0 12px 0', fontSize: '14px', fontWeight: '600' }}>
<h3 style={{ margin: '0 0 12px', fontSize: '14px', fontWeight: '600' }}>

/>

<ImportCard>
<h2 style={{ margin: '0 0 1em 0' }}>{__('Choose Files', 'code-snippets')}</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2 style={{ margin: '0 0 1em 0' }}>{__('Choose Files', 'code-snippets')}</h2>
<h2 style={{ margin: '0 0 1em' }}>{__('Choose Files', 'code-snippets')}</h2>

<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginBlockEnd: '10px' }}>
<div>
<h3 style={{ margin: '0' }}>{__('Available Snippets', 'code-snippets')} ({importWorkflow.availableSnippets.length})</h3>
<p style={{ margin: '0.5em 0 1em 0', color: '#666' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p style={{ margin: '0.5em 0 1em 0', color: '#666' }}>
<p style={{ margin: '0.5em 0 1em', color: '#666' }}>

return (
<ImportCard variant="controls">
<label htmlFor="importer-select">
<h2 style={{ margin: '0 0 1em 0' }}>{__('Select Plugin', 'code-snippets')}</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2 style={{ margin: '0 0 1em 0' }}>{__('Select Plugin', 'code-snippets')}</h2>
<h2 style={{ margin: '0 0 1em' }}>{__('Select Plugin', 'code-snippets')}</h2>

<ImportCard>
<div style={{ textAlign: 'center', padding: '40px 20px', color: '#666' }}>
<div style={{ fontSize: '48px', marginBlockEnd: '16px' }}>📭</div>
<h3 style={{ margin: '0 0 8px 0', fontSize: '18px', color: '#333' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3 style={{ margin: '0 0 8px 0', fontSize: '18px', color: '#333' }}>
<h3 style={{ margin: '0 0 8px', fontSize: '18px', color: '#333' }}>

}}
>
<div style={{ fontSize: '48px', marginBlockEnd: '10px', color: '#666' }}>📁</div>
<p style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '500' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '500' }}>
<p style={{ margin: '0 0 8px', fontSize: '16px', fontWeight: '500' }}>

}) => {
return (
<ImportCard>
<h2 style={{ margin: '0 0 1em 0' }}>{__('Duplicate Snippets', 'code-snippets')}</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2 style={{ margin: '0 0 1em 0' }}>{__('Duplicate Snippets', 'code-snippets')}</h2>
<h2 style={{ margin: '0 0 1em' }}>{__('Duplicate Snippets', 'code-snippets')}</h2>

</span>
</div>
<div style={{ flex: 1 }}>
<h3 style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '600' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3 style={{ margin: '0 0 8px 0', fontSize: '16px', fontWeight: '600' }}>
<h3 style={{ margin: '0 0 8px', fontSize: '16px', fontWeight: '600' }}>

: __('Import Failed', 'code-snippets')
}
</h3>
<p style={{ margin: '0 0 8px 0', color: '#666' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p style={{ margin: '0 0 8px 0', color: '#666' }}>
<p style={{ margin: '0 0 8px', color: '#666' }}>

Copy link
Contributor

@ramiy ramiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent design - 4px border-radius.

}

return (
<table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px', tableLayout: 'fixed' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px', tableLayout: 'fixed' }}>
<table className="wp-list-table widefat fixed striped" style={{ borderRadius: '4px', tableLayout: 'fixed' }}>

padding: '3px 6px',
fontSize: '10px',
textTransform: 'uppercase',
borderRadius: '3px'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
borderRadius: '3px'
borderRadius: '4px'

</div>
</div>

<table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<table className="wp-list-table widefat fixed striped" style={{ borderRadius: '5px' }}>
<table className="wp-list-table widefat fixed striped" style={{ borderRadius: '4px' }}>

const cardStyle: React.CSSProperties = {
backgroundColor: '#ffffff',
padding: '25px',
borderRadius: '5px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
borderRadius: '5px',
borderRadius: '4px',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Adding this label will trigger the zip build action run-tests Trigger automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants